#25 Regression on commit 8b896fe7e7 (Fixed isdecimal check)

Closed
opened 1 month ago by digitalec · 1 comments

When downloading singles, I'm receiving an AttributeError:

Traceback (most recent call last):
  File "/home/digitalec/.local/bin/deemix", line 8, in <module>
    sys.exit(download())
  File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__main__.py", line 107, in download
    downloadLinks(url, bitrate)
  File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__main__.py", line 75, in downloadLinks
    downloadObject = generateDownloadObject(dz, link, bitrate, plugins, listener)
  File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__init__.py", line 66, in generateDownloadObject
    return generateAlbumItem(dz, link_id, bitrate)
  File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/itemgen.py", line 86, in generateAlbumItem
    return generateTrackItem(dz, albumAPI['tracks']['data'][0]['id'], bitrate, albumAPI=albumAPI)
  File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/itemgen.py", line 24, in generateTrackItem
    if not str(link_id.strip('-')).isdecimal(): raise InvalidID(f"https://deezer.com/track/{link_id}")
AttributeError: 'int' object has no attribute 'strip'

This does not effect albums. Reverting this particular commit resolves this issue.

When downloading singles, I'm receiving an AttributeError: ``` Traceback (most recent call last): File "/home/digitalec/.local/bin/deemix", line 8, in <module> sys.exit(download()) File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1137, in __call__ return self.main(*args, **kwargs) File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1062, in main rv = self.invoke(ctx) File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 1404, in invoke return ctx.invoke(self.callback, **ctx.params) File "/home/digitalec/.local/lib/python3.9/site-packages/click/core.py", line 763, in invoke return __callback(*args, **kwargs) File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__main__.py", line 107, in download downloadLinks(url, bitrate) File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__main__.py", line 75, in downloadLinks downloadObject = generateDownloadObject(dz, link, bitrate, plugins, listener) File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/__init__.py", line 66, in generateDownloadObject return generateAlbumItem(dz, link_id, bitrate) File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/itemgen.py", line 86, in generateAlbumItem return generateTrackItem(dz, albumAPI['tracks']['data'][0]['id'], bitrate, albumAPI=albumAPI) File "/home/digitalec/.local/lib/python3.9/site-packages/deemix/itemgen.py", line 24, in generateTrackItem if not str(link_id.strip('-')).isdecimal(): raise InvalidID(f"https://deezer.com/track/{link_id}") AttributeError: 'int' object has no attribute 'strip' ``` This does not effect albums. Reverting this particular commit resolves this issue.
Poster

Issue resolved in commit b9da32b2a2. Thanks

Issue resolved in commit b9da32b2a2. Thanks
digitalec closed this issue 1 month ago
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.