RemixDev
/
deemix-py
5
9
Fork 5
Code Issues 3 Pull Requests 0 Projects 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#1 feat: user can change illegal characters in config file

Closed
donmerendolo wants to merge 1 commits from donmerendolo/deemix-py:illegal-characters into refactoring
Conversation 3 Commits 1 Files Changed 2
donmerendolo commented 6 months ago

Added an illegalCharacters variable in the config.json file, as they can differ from filesystem to filesystem (or operating system). The default value is [\u0000\/\:*?"<>|]. Also changed fixName() in pathtemplates.py and its arguments.

Sorry if there is anything wrong. This is my first pull request.

Added an `illegalCharacters` variable in the config.json file, as they can differ from filesystem to filesystem (or operating system). The default value is `[\u0000\/\:*?"<>|]`. Also changed `fixName()` in pathtemplates.py and its arguments. Sorry if there is anything wrong. This is my first pull request.
donmerendolo added 1 commit 6 months ago
RemixDev commented 6 months ago
Poster
Owner

Making the regex a user configurable setting is not the best of ideas, maybe it's better to change the regex based on the os.

Making the regex a user configurable setting is not the best of ideas, maybe it's better to change the regex based on the os.
donmerendolo commented 6 months ago
Poster

I thought about that but didn't find any module or anything. Maybe detecting the filesystem the folder is in with something like this https://stackoverflow.com/questions/25283882/determining-the-filesystem-type-from-a-path-in-python and selecting the correct group in a dictionary? I don't know how to implement that but can try.

I thought about that but didn't find any module or anything. Maybe detecting the filesystem the folder is in with something like this https://stackoverflow.com/questions/25283882/determining-the-filesystem-type-from-a-path-in-python and selecting the correct group in a dictionary? I don't know how to implement that but can try.
donmerendolo commented 6 months ago
Poster

Nope, can't do this properly. Will use a script.

Nope, can't do this properly. Will use a script.
RemixDev closed this pull request 4 months ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'donmerendolo/deemix-py:illegal-characters'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes