fix KeyError in convertTrack and generateTrackItem

New Pull Request

Conversation 1 Commits 1 Files Changed 1

in Spotify class.

jojo added 1 commit 3 months ago

c4f11aef7c fix KeyError in convertTrack and generateTrackItem

in Spotify class

RemixDev reviewed 3 months ago

deemix/plugins/spotify.py

												
					                    self.saveCache(cache)
				
					            if cachedTrack['id'] != "0": return generateTrackItem(dz, cachedTrack['id'], bitrate)
				
					            if 'id' in cachedTrack and cachedTrack['id'] != "0":

RemixDev commented 3 months ago

This can be changed with cachedTrack.get('id')

RemixDev reviewed 3 months ago

deemix/plugins/spotify.py

												
					                    self.saveCache(cache)
				
					            if cachedTrack['id'] != "0": trackAPI = dz.api.get_track(cachedTrack['id'])
				
					            if 'id' in cachedTrack and cachedTrack['id'] != "0":

RemixDev commented 3 months ago

Same here

RemixDev merged commit caee30f37c into main 3 months ago

RemixDev referenced this issue from a commit 3 months ago

Merge pull request 'fix KeyError in convertTrack and generateTrackItem' (#20) from jojo/deemix-py:spotify_fix into main

yes that definitely would have been the nicer solution! sorry I didn't check for a reply on this pr right away. you merged already, would you appreciate another pr fixing it? (or better use my time for future fixes?)

The pull request has been merged as caee30f37c.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#20 fix KeyError in convertTrack and generateTrackItem