exttex
/
freezer
8
9
Fork 7
Code Issues 28 Pull Requests 0 Projects 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#7 login screen redesign, make lyrics clickable, animated play/pause icon and code fixes

Closed
pato05 wants to merge 0 commits from pato05:patch-1 into master
Conversation 2 Commits N/A Files Changed N/A
pato05 commented 7 months ago

The title says it all, in the "fixes" I substituted the deprecated widgets (FlatButton, OutlinedButton, RaisedButton) with the new ones (TextButton, OutlineButton, ElevatedButton), and made some extra changes to make the linter happy (partially).

I didn't manage to fix the glitched statusBarIcons' brightness though. If I'll eventually be able to, I'll make another Pull Request.

The title says it all, in the "fixes" I substituted the deprecated widgets (FlatButton, OutlinedButton, RaisedButton) with the new ones (TextButton, OutlineButton, ElevatedButton), and made some extra changes to make the linter happy (partially). I didn't manage to fix the glitched statusBarIcons' brightness though. If I'll eventually be able to, I'll make another Pull Request.
Screenshot_20210405-010649_Freezer.png
90 KiB
exttex commented 7 months ago
Poster
Owner

I appreciate your efforts, but uh contributing to dead apps isn't a good idea. I usually don't merge PRs, because I am locally ahead and just push here releases.

  1. The statusbar icon brightness i already fixed locally
  2. Login screen redesign might merge some of the issues
  3. Lyrics if i get time

So yeah, won't be merging now because of conflicts.

I appreciate your efforts, but uh contributing to dead apps isn't a good idea. I usually don't merge PRs, because I am locally ahead and just push here releases. 1. The statusbar icon brightness i already fixed locally 2. Login screen redesign might merge some of the issues 3. Lyrics if i get time So yeah, won't be merging now because of conflicts.
exttex closed this pull request 7 months ago
pato05 commented 7 months ago
Poster

oh well thank you anyway, welp i just pushed another little change to the lyrics thing and further improvements in the settings_screen, I'd appreciate if you'll eventually merge that as well. If you need any help with the app, I'd appreciate to, just ping me on telegram (@pato05)

oh well thank you anyway, welp i just pushed another little change to the lyrics thing and further improvements in the settings_screen, I'd appreciate if you'll eventually merge that as well. If you need any help with the app, I'd appreciate to, just ping me on telegram ([@pato05](https://t.me/pato05))
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pato05:patch-1'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes