exttex
/
freezerpc
3
8
Fork 17
Code Issues 14 Pull Requests 6 Projects 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#28 (WIP) Fix some bugs and improve Russian TL

Closed
chayleaf wants to merge 7 commits from chayleaf/freezerpc:master into master
Conversation 2 Commits 7 Files Changed 3
chayleaf commented 3 months ago

Sorry for not making this a few separate PRs I guess?

  • Improve Russian TL
  • Fix pause() firing when the track hasn't started playing yet sometimes (which is illegal: https://developers.google.com/web/updates/2017/06/play-request-was-interrupted)
  • Make prev button seek to track start if position is more than 10s
  • Save playback info when pressing prev button
  • Fix repeat mode toggle button not showing sometimes (There was a button, but it didn't have an icon and didn't do anything)
  • Make media keys work on startup (so you don't have to press play manually once)
  • Use MediaSession API more (setPositionState, more event handlers)
  • Still has some bugs I noticed and don't know how to fix!
Sorry for not making this a few separate PRs I guess? - Improve Russian TL - Fix pause() firing when the track hasn't started playing yet sometimes (which is illegal: https://developers.google.com/web/updates/2017/06/play-request-was-interrupted) - Make prev button seek to track start if position is more than 10s - Save playback info when pressing prev button - Fix repeat mode toggle button not showing sometimes (There was a button, but it didn't have an icon and didn't do anything) - Make media keys work on startup (so you don't have to press play manually once) - Use MediaSession API more (setPositionState, more event handlers) - Still has some bugs I noticed and don't know how to fix!
chayleaf added 4 commits 3 months ago
256906e954 fix loop icon not showing sometimes
chayleaf changed title from Fix some bugs and improve Russian TL to (WIP) Fix some bugs and improve Russian TL 3 months ago
chayleaf added 1 commit 3 months ago
chayleaf changed title from (WIP) Fix some bugs and improve Russian TL to Fix some bugs and improve Russian TL 3 months ago
chayleaf added 1 commit 3 months ago
chayleaf added 1 commit 3 months ago
chayleaf changed title from Fix some bugs and improve Russian TL to (WIP) Fix some bugs and improve Russian TL 3 months ago
chayleaf commented 3 months ago
Poster

Alright, I still need to sort out some bugs... will send a notice when I'm done

Alright, I still need to sort out some bugs... will send a notice when I'm done
chayleaf commented 3 months ago
Poster

i'll make this into a few PRs properly-ish

i'll make this into a few PRs properly-ish
chayleaf closed this pull request 3 months ago
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'chayleaf/freezerpc:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes