Refactor playback

New Pull Request

Conversation 0 Commits 5 Files Changed 16

Fix pause() firing before play() finishes (which is illegal)
Allow seeking/pausing before the track even loads
Make rapid skipping more efficient
Fix loop button sometimes not showing
Make next/prev buttons loop (if loop is enabled)
Make prev button seek to start if position is > 10 seconds
Use audio.loop for looping single track
Save playback info in more cases
Possibly some other stuff I felt like changing that may or may not affect anything

chayleaf added 1 commit 3 months ago

436718dc36 heavily refactor playback

Fix pause() firing before play() finishes (which is illegal)
Allow seeking/pausing before the track even loads
Make rapid skipping more efficient
Fix loop button sometimes not showing
Make next/prev buttons loop
Make prev button seek to start if position is > 10 seconds
Use audio.loop for looping single track
Save playback info in more cases
Possibly some other stuff I felt like changing that may or may not
affect anything

chayleaf changed title from ~~Heavily refactor playback~~ to Refactor playback 3 months ago

chayleaf added 1 commit 3 months ago

43d0e74e9f remove outdated comment

chayleaf added 1 commit 3 months ago

59483fd2b0 fix lyrics and playback position not updating in some UIs

chayleaf added 1 commit 3 months ago

ec9074bda3 typos

chayleaf added 1 commit 3 months ago

1cbba249a4 update position in ui when seeking not via ui

This pull request can be merged automatically.

You are not authorized to merge this pull request.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

#29 Refactor playback