exttex
/
freezerpc
3
8
Fork 17
Code Issues 14 Pull Requests 6 Projects 0 Releases 0 Wiki Activity
Labels Milestones
New Pull Request

#3 Readd light theme

Closed
Ghost wants to merge 1 commits from <deleted>:master into master
Conversation 2 Commits 1 Files Changed 3
Ghost commented 7 months ago

As described in issue #2, the Android app has an option for a light theme (along with a toggle to follow the system theme) which the desktop app is currently lacking. After looking over past commits, I discovered this was actually supported at one point, but then removed. This pull request readds it, but I'd still like some help doing the following:

  • Adding support for following the system theme (wasn't in the earlier commit)
  • Apply the light theme to the whole app (currently some parts such as the player are not properly themed in the light theme, this issue was also present in the earlier commit)

Thanks for all your help and for developing this great app!

As described in issue #2, the Android app has an option for a light theme (along with a toggle to follow the system theme) which the desktop app is currently lacking. After looking over past commits, I discovered this was actually supported at one point, but then removed. This pull request readds it, but I'd still like some help doing the following: - Adding support for following the system theme (wasn't in the earlier commit) - Apply the light theme to the whole app (currently some parts such as the player are not properly themed in the light theme, this issue was also present in the earlier commit) Thanks for all your help and for developing this great app!
Ghost added 1 commit 7 months ago
Ghost commented 7 months ago
Poster

It's also worth noting, as a justification, that Deezer itself has a light theme. So this would be better for continuity!

It's also worth noting, as a justification, that Deezer itself has a light theme. So this would be better for continuity!
Ghost commented 7 months ago
Poster

Since developement seems to have been halted or at least postponed (and since this is not a "bug"), I'm closing this issue (and my account). Thanks for making this app and hopefully you'll continue to work on it!

Since developement seems to have been halted or at least postponed (and since this is not a "bug"), I'm closing this issue (and my account). Thanks for making this app and hopefully you'll continue to work on it!
Ghost closed this pull request 7 months ago
This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch '<deleted>:master'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes